Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add initial meson support #306

Merged
merged 7 commits into from
Feb 8, 2024
Merged

build: add initial meson support #306

merged 7 commits into from
Feb 8, 2024

Conversation

brenfwd
Copy link
Contributor

@brenfwd brenfwd commented Sep 24, 2023

This PR adds initial support for the meson build system. Currently set up to work as a shared/static library, since that works best with meson's dependency system for libuv.

This should be able to be backported to the current release as well if desired.

@skypjack
Copy link
Owner

Maybe it's worth it to add a note to the build instructions here?
Otherwise, please drop a few lines in a comment and I can add them to the readme file. I think we should to the same with vcpkg anyway.

@brenfwd
Copy link
Contributor Author

brenfwd commented Sep 26, 2023

Updated build instructions, lmk what you think :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@skypjack
Copy link
Owner

skypjack commented Sep 28, 2023

@stefanofiorentino any concerns? I'm about to merge this one otherwise.

@brenfwd
Copy link
Contributor Author

brenfwd commented Dec 12, 2023

@skypjack @stefanofiorentino good to merge?

@skypjack
Copy link
Owner

Actually, I don't have enough knowledge to say if it's good to merge for the meson part.
I'm fine with merging it but I won't be able to maintain it in the long run because I'm not into meson.
I'm sorry. Is there any way to test it on the CI and have red flag in case of failure?

@skypjack
Copy link
Owner

skypjack commented Feb 6, 2024

Ping @brenfwd ☝️

@brenfwd
Copy link
Contributor Author

brenfwd commented Feb 7, 2024

I believe this should do the trick.

https://github.com/brenfwd/uvw/actions/runs/7817930848/job/21326979681

@brenfwd
Copy link
Contributor Author

brenfwd commented Feb 7, 2024

(renamed commit msg)

@skypjack skypjack merged commit ba10b27 into skypjack:main Feb 8, 2024
49 checks passed
@skypjack
Copy link
Owner

Meson support is broken. As anticipated, I don't have enough knowledge nor bandwidth to maintain it.
@brenfwd are you willing to help with it? I'm afraid I'll have to drop it otherwise. Please, let me know. Thanks.

@brenfwd
Copy link
Contributor Author

brenfwd commented May 13, 2024

@skypjack Sure thing, will look into it and PR a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants