Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for GCC/Clang compiler warnings in Ubuntu GitHub Actions CI #304

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Check for GCC/Clang compiler warnings in Ubuntu GitHub Actions CI #304

merged 1 commit into from
Sep 6, 2023

Commits on Sep 1, 2023

  1. ci: fail Ubuntu CI if there are compiler warnings 

    Add a [`CMakePresets.json`][1] file that contains `ci-ubuntu` preset.
This preset contains most of the recommended compiler warnings from the
[`cmake-init`][2] project.

However, I had to remove the `-Wdouble-promotion` and
`-Werror=float-equal` flags since there are issues within the GTest
headers.

For compatibility with g++-7, `-Wextra-semi` was removed.

I also had to remove some of the following flags like:
`-fstack-protector-strong -fstack-clash-protection`.
These flags cause errors in Clang v10 (still run in CI), and to be
honest, with stuff like address sanitizer, we probably don't need them.

[1]: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html
[2]: https://github.com/friendlyanon/cmake-init/blob/aa42211c79ab5117b05a2d9f795427f078a0a3d5/cmake-init/templates/common/CMakePresets.json#L88
    @aloisklink
    aloisklink committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    209d67a View commit details
    Browse the repository at this point in the history