meta: meta_sequence_container::resize support to non default construc…

…tible types (close #1072)
skypjack · Oct 5, 2023 · 8848040 · 8848040
1 parent 33ef814
commit 8848040
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/entt/meta/container.hpp b/src/entt/meta/container.hpp
@@ -117,7 +117,7 @@ struct basic_meta_sequence_container_traits {
      * @return True in case of success, false otherwise.
      */
     [[nodiscard]] static bool resize([[maybe_unused]] void *container, [[maybe_unused]] const size_type sz) {
-        if constexpr(internal::dynamic_sequence_container_v<Type>) {
+        if constexpr(internal::dynamic_sequence_container_v<Type> && std::is_default_constructible_v<typename Type::value_type>) {
             static_cast<Type *>(container)->resize(sz);
             return true;
         } else {

diff --git a/test/entt/meta/meta_container.cpp b/test/entt/meta/meta_container.cpp
@@ -15,6 +15,10 @@
 
 struct invalid {};
 
+struct non_default_constructible {
+    non_default_constructible() = delete;
+};
+
 TEST(MetaContainer, Invalid) {
     ASSERT_FALSE(entt::meta_any{42}.as_sequence_container());
     ASSERT_FALSE(entt::meta_any{42}.as_associative_container());
@@ -319,6 +323,14 @@ TEST(SequenceContainer, StdDeque) {
     ASSERT_EQ(view.size(), 0u);
 }
 
+TEST(SequenceContainer, NonDefaultConstructible) {
+    std::vector<non_default_constructible> vec{};
+    auto any = entt::forward_as_meta(vec);
+    auto view = any.as_sequence_container();
+
+    ASSERT_FALSE(view.resize(5u));
+}
+
 TEST(SequenceContainer, Constness) {
     std::vector<int> vec{};
     auto any = entt::forward_as_meta(std::as_const(vec));