[Jobs] Refactor: Extract task failure state update helper #4185
+28
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andylizf
changed the title
|
@cblmemo PTAL, thanks! |
andylizf
force-pushed
the
refactor-except
branch
from
0664104
to
7f95bc0
Compare
cblmemo
reviewed
Oct 26, 2024
sky/jobs/controller.py
Outdated
Comment on lines
384
to
385
| if task_id is None: | ||
| return |
There was a problem hiding this comment.
In what case will we enter this branch?
There was a problem hiding this comment.
Good catch! Thanks for pointing out.
andylizf
force-pushed
the
refactor-except
branch
from
466c9bb
to
2ec69cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract repeated task failure state update logic into
_update_failed_task_state()helper to reduce code duplication.Originally posted by @cblmemo in #4128 (comment)
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh