Remove --system-site-packages when setup sky cluster #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Oct 25, 2024
There was a problem hiding this comment.
For this, we may want to check the performance regression. IIRC, this can cause significant time increase for the dependency installation. For longer time on user's own cloud image should be ok, but we may want to check the performance degradation with some commonly used docker images, as well as the our default k8s image.
~5s increase in perf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #4097
Remove the flag so that sky's venv won't link to the global (system) site-packages directory which can be modified by users.
Performance regression: ~5s
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.py::test_minimal