Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delete resource in case of wait for readiness fail #191

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Do not delete resource in case of wait for readiness fail #191

merged 1 commit into from
Oct 21, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Oct 21, 2024

Description

Do not delete resource in case wait fail, it can cause issues during collecting of artifacts.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit/integration tests pass locally with my changes

@kornys kornys self-assigned this Oct 21, 2024
@kornys kornys enabled auto-merge (squash) October 21, 2024 16:50
@kornys kornys merged commit 7ae6878 into main Oct 21, 2024
7 checks passed
@kornys kornys deleted the fix-rm-wait branch October 21, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-konge im-konge im-konge approved these changes

@Frawless Frawless Frawless approved these changes

Assignees

@kornys kornys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kornys @Frawless @im-konge