Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original metric in String to the Metric object #178

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

im-konge
Copy link
Member

Description

Because we are checking the existence of some metric using regexes, it would be worth having the full/original metric in String stored inside the Metric object.
That way we can also see from what was the particular metric object parsed.

This PR adds stringMetric variable to the Metric object, which will contain exactly this value. Because it enhances the default constructor, the constructors (and the creation of each object) had to be changed as well.

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@im-konge im-konge merged commit 5d59c50 into main Aug 30, 2024
7 checks passed
@im-konge im-konge deleted the add-string-metric-variable branch August 30, 2024 07:48
@kornys kornys added this to the 0.6.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants