Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getValue() method to Counter type metric #177

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

im-konge
Copy link
Member

Description

The Counter metric type is the only one missing the getValue() method, which is used for obtaining the value parameter from the Counter object.
This PR adds it to the code.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit/integration tests pass locally with my changes

@im-konge im-konge merged commit 6290b63 into main Aug 30, 2024
7 checks passed
@im-konge im-konge deleted the return-value-counter branch August 30, 2024 06:17
@kornys kornys added this to the 0.6.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants