Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use composer 2 as default #292

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Use composer 2 as default #292

merged 1 commit into from
Oct 30, 2020

Conversation

andypost
Copy link
Contributor

@andypost andypost commented Oct 25, 2020

To switch versions use:

  • ln -fs composer2 /usr/bin/composer
  • ln -fs composer1 /usr/bin/composer

Related to skilld-labs/docker-php@2fa0631

@andypost
Copy link
Contributor Author

It makes #277 outdated (except back task in CI)

when #290 will be commited as cache it will speed-up things bit more

To switch versions use:
- `ln -fs composer2 /usr/bin/composer`
- `ln -fs composer1 /usr/bin/composer`
@andypost
Copy link
Contributor Author

Rebased as #277 been commited

@andypost
Copy link
Contributor Author

@davidferlay davidferlay merged commit 97d9829 into master Oct 30, 2020
@davidferlay
Copy link
Contributor

Merging this as tested and working fine

However i'm wandering if we shouldn't add these lines also to make provision as it can happen independently to make back (like here for RA)

        # Set composer2 as default
        $(call php-0, ln -fs composer2 /usr/bin/composer)
ifneq ($(strip $(ADD_PHP_EXT)),)
# Install additional php extensions as this goal used in CI (todo stop doing it)
        $(call php-0, apk add --no-cache $(ADD_PHP_EXT))

What are you thoughts on that @andypost ?

@andypost andypost deleted the composer2 branch October 30, 2020 17:48
@andypost
Copy link
Contributor Author

andypost commented Oct 30, 2020

@davidferlay no reason because provision runs before back and there's no composer involved

OTOH of we add it here, then back will not use it in CI (so we should stop using make back in CI https://github.com/skilld-labs/skilld-docker-container/blob/master/.gitlab-ci.yml#L130

@davidferlay
Copy link
Contributor

provision runs before back

In locals yes, but not in CI. So i'm wondering if it's useful or not to use composer 2 when RA is brought up

@andypost
Copy link
Contributor Author

andypost commented Oct 31, 2020

Yes, that's why for CI just using composer 2 is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants