Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email notifications for tasks and challenges #148

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Sep 23, 2014

  1. Configuration menu
    Copy the full SHA
    20a284f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2014

  1. Configuration menu
    Copy the full SHA
    d000fbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4663204 View commit details
    Browse the repository at this point in the history
  3. Add email send buttons to challenges and tasks

    Created EmailNotificationsController#new_challenge and #new_task
    georgyangelov committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    e64dd3c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f4a97c View commit details
    Browse the repository at this point in the history
  5. Split long lines to multiple ones

    In views/challenges/show and views/tasks/show
    georgyangelov committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    9183dfa View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2014

  1. Configuration menu
    Copy the full SHA
    fdbcdea View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2014

  1. Move some tests out of the shared ones for the mailers

    The shared examples in their previous form could not be used for
    any other mailer, even though there may be other mailers that send
    emails to multiple users. Also, the parametrization of the shared
    examples makes it harder to follow the expectations of the tests.
    
    Now, only the examples for the `#new_challenge` and `#new_task` methods
    are shared. This will make the shared test usable for other mailers.
    The other option is to make another mailer whose job is to retrieve
    all users from the database and call another mailer, but the method
    itself is small and making it more generic will be almost like
    recreating the functionality of `User.where.each`.
    
    The expectations in the separate mailer spec files are similar, but
    for other similar mailers they may be different. For example an
    announcement mailer would not contain the title of the announcement
    in the body text (only in the subject) and would not use
    `announcement_url(announcement)` to generate its URL.
    georgyangelov committed Sep 27, 2014
    Configuration menu
    Copy the full SHA
    259bd04 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2014

  1. Configuration menu
    Copy the full SHA
    1329330 View commit details
    Browse the repository at this point in the history