-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email notifications for tasks and challenges #148
Open
georgyangelov
wants to merge
9
commits into
skanev:master
Choose a base branch
from
georgyangelov:email-notifications
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 23, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 20a284f - Browse repository at this point
Copy the full SHA 20a284fView commit details
Commits on Sep 24, 2014
-
Configuration menu - View commit details
-
Copy full SHA for d000fbb - Browse repository at this point
Copy the full SHA d000fbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4663204 - Browse repository at this point
Copy the full SHA 4663204View commit details -
Add email send buttons to challenges and tasks
Created EmailNotificationsController#new_challenge and #new_task
Configuration menu - View commit details
-
Copy full SHA for e64dd3c - Browse repository at this point
Copy the full SHA e64dd3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f4a97c - Browse repository at this point
Copy the full SHA 2f4a97cView commit details -
Split long lines to multiple ones
In views/challenges/show and views/tasks/show
Configuration menu - View commit details
-
Copy full SHA for 9183dfa - Browse repository at this point
Copy the full SHA 9183dfaView commit details
Commits on Sep 25, 2014
-
Configuration menu - View commit details
-
Copy full SHA for fdbcdea - Browse repository at this point
Copy the full SHA fdbcdeaView commit details
Commits on Sep 27, 2014
-
Move some tests out of the shared ones for the mailers
The shared examples in their previous form could not be used for any other mailer, even though there may be other mailers that send emails to multiple users. Also, the parametrization of the shared examples makes it harder to follow the expectations of the tests. Now, only the examples for the `#new_challenge` and `#new_task` methods are shared. This will make the shared test usable for other mailers. The other option is to make another mailer whose job is to retrieve all users from the database and call another mailer, but the method itself is small and making it more generic will be almost like recreating the functionality of `User.where.each`. The expectations in the separate mailer spec files are similar, but for other similar mailers they may be different. For example an announcement mailer would not contain the title of the announcement in the body text (only in the subject) and would not use `announcement_url(announcement)` to generate its URL.
Configuration menu - View commit details
-
Copy full SHA for 259bd04 - Browse repository at this point
Copy the full SHA 259bd04View commit details
Commits on Nov 10, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 1329330 - Browse repository at this point
Copy the full SHA 1329330View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.