15 add tests #17
Merged
15 add tests #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a fake Couchbase session - Perform insert, upsert, get, and remove actions on fake Couchbase class.
- Renamed LICENSE.rst -> LICENSE - Renamed README.rst -> README.md - Updated setup.cfg, most importantly updating to correct license statement. Also added 'fake' as a package to indlude. - Added '__pycache__' to .gitignore. Can't fathom I hadn't already...
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added initial version of fake-couchbase
chore: updated package files
statement. Also added 'fake' as a package to indlude.
chore: added requirements files
Added requirements files for local development.
feat: added datetime utcnow hack
Supporting multiple Python versions due to the deprecation warning for
datetime.datetime.utcnow()in a future release.feat: added initial set of tests
Added tests for insert[_multi] and upsert[_multi] methods, as well as session validations.
feat: added tests for get methods
Added tests for get[_multi] methods.
chore: cleaned up unused globals in session test
Minor cleanup.
fix: fixed delay in couchbase_helper.fake.Cluster.wait_until_ready
The method
couchbase_helper.fake.Cluster.wait_until_ready()was causing too long processing times which didn't mimic real world Couchbase time spent.feat: added 'get_multi' to fake collection class
Added support for
get_multiin the package's fake collection class.feat: added proper return value in fake store class
The return value of
couchbase_helper.fake.store._get()method was aligned with the Couchbase package's C-library response for get actions of it'skv_operation()function.chore: undid making SessionProt runtime checkable for test purposes
Making
couchbase_helper.protocols.SessionProtclass runtime checkable wasn't really optimized, so this was undone. This was only done for tests anyway, so a "hack" was done in thetests.test_session.pyinstead which basically extends theSessionProtprotocol and making that extended class runtime checkable instead. This should ensure performance isn't affected outside of the tests, which shouldn't matter for the primary use case of this package.Limited scope
As issue #9 is due, tests for the
couchbase_helper.helper.n1ql()method will not be included. Same is applicable for thecouchbase_helper.helper.view_query()method even though no issue is open (yet) for its refinement/rewrite.Hence both will not be part of this PR, it should be included as part of the PR when they are updated.