Don't go from Idle(UAC) straight to the Dead state. The problem with

that, is Dead's OnActivate() cleans up all callback pointers, thus making a subsequent self.ua.DiscCb() effectively a NOP.
sippy · Oct 26, 2024 · 9c3ce23 · 9c3ce23
1 parent 70741e4
commit 9c3ce23
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/sippy/uac_state_idle.go b/sippy/uac_state_idle.go
@@ -160,7 +160,7 @@ func (self *UacStateIdle) RecvEvent(_event sippy_types.CCEvent) (sippy_types.UaS
         disconnect_ts, _ := sippy_time.NewMonoTime()
         self.ua.SetDisconnectTs(disconnect_ts)
     }
-    return NewUaStateDead(self.ua, self.config), func() { self.ua.DiscCb(_event.GetRtime(), _event.GetOrigin(), 0, nil) }, nil
+    return NewUaStateDisconnected(self.ua, self.config), func() { self.ua.DiscCb(_event.GetRtime(), _event.GetOrigin(), 0, nil) }, nil
 }
 
 func (self *UacStateIdle) ID() sippy_types.UaStateID {