-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
su for contest admins #400
Merged
MasloMaslane
merged 13 commits into
sio2project:master
from
MasloMaslane:su-for-contest-admins
Sep 11, 2024
Merged
su for contest admins #400
MasloMaslane
merged 13 commits into
sio2project:master
from
MasloMaslane:su-for-contest-admins
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-dead-pixel
reviewed
Sep 4, 2024
A-dead-pixel
requested changes
Sep 7, 2024
A-dead-pixel
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option for contest admins to su to participants in contests they admin. By default this option is disabled and can be enabled by setting
CONTEST_ADMINS_CAN_SU
toTrue
insettings.py
. Also by default, contest admins using su can't make requests other than GET. This can be changed by settingALLOW_ONLY_GET_FOR_SU_CONTEST_ADMINS
toTrue
in settings.When a contest admin using su tries to change to another contest or go to an url which is not in the contest (doesn't have
/c/id/...
), they are redirected to the dashboard of the original contest. This unfortunately still allows to go to to sites like editing profile info, because the url starts with/c/id/
. This is the reason that by default only GET requests are allowed.This feature is highly sought after by the OI Jury