Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New How it works modal on HomePage and minor UX tweeks #37

Merged
merged 15 commits into from
Mar 27, 2023

Conversation

sandeshvijayraj
Copy link
Contributor

@sandeshvijayraj sandeshvijayraj commented Mar 21, 2023

Summary

Added a new modal on HomePage called "how it works" that explains to the user how the connection to singlestore works in RTDM. This will help users to know what they have to do in order to use RTDM

Test Plan

  1. Pull the MR and from the terminal go to the web folder using the command cd ./web
  2. In case you are using the RTDM project for the first time install dependencies using yarn install
  3. Start the service using yarn dev
  4. Visit http://localhost:3000/configuration

You can follow the "Test Plan" to experience the changes

homepagetweek.mp4

Changes

  • New "How it works" modal on HomePage.
  • All Headers font size changes in /dashboard, /configure, /analytics sections.

Subscribers

@mivasconcelos @TitoGrine

@sandeshvijayraj sandeshvijayraj changed the title Sandesh/restructure home page New How it works modal on HomePage and minor UX tweeks Mar 21, 2023
.gitignore Outdated Show resolved Hide resolved
Copy link

@TitoGrine TitoGrine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 🎉

One thing though, I'm not a big fan of where we are putting the How it works? link and also the wording of it. "How it works?" seems like we are going to explain how the RTDM app works, not a guide on how to fill in the login form... 😕

I'm not sure what the best approach here is, maybe you should ask Jennifer for input here.
I experimented with some stuff and I was thinking of something more along the lines of this:

Screenshot from 2023-03-21 23-12-38

But I'm not 100% happy with it either.

Any thoughts on this @mivasconcelos?

web/src/components/HowItWorksModal.tsx Outdated Show resolved Hide resolved
>
<Stack justifyContent="center" alignItems="center" gap="26px">
<ModalHeader fontSize="26px" fontWeight="bold" padding="8px">
How Real-Time Digital marketing app works?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
How Real-Time Digital marketing app works?
How does the Real-Time Digital marketing app work?

Copy link
Contributor Author

@sandeshvijayraj sandeshvijayraj Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I do not like either of the statement. We are not explaining how the RTDM works rather we are explaining how the connection to singlestoreDB works

Should we better rename it something like

"How does the connection to singlesytoreDB work in RTDM?"
?? @TitoGrine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. What about: "How to connect to the Real-Time Digital marketing app?"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeded, what do you think about:

"How to connect the Real-Time Digital marketing app to SingleStoreDB?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"How to connect the Real-Time Digital marketing app to SingleStoreDB?"

This one is better

what do you think @mivasconcelos

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deal! It seems good to me

Copy link
Contributor

@mivasconcelos mivasconcelos Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just add a screenshot just to make sure it isn't too long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-03-24 11-33-31

@mivasconcelos
Copy link
Contributor

Looks awesome tada

One thing though, I'm not a big fan of where we are putting the How it works? link and also the wording of it. "How it works?" seems like we are going to explain how the RTDM app works, not a guide on how to fill in the login form... confused

I'm not sure what the best approach here is, maybe you should ask Jennifer for input here. I experimented with some stuff and I was thinking of something more along the lines of this:

Screenshot from 2023-03-21 23-12-38

But I'm not 100% happy with it either.

Any thoughts on this @mivasconcelos?

I prefer the "Need help" wording but I think it looks like a new tab and it might be odd to open a modal when clicked... I don't find a better place to have it. Maybe we can keep the placement but change the wording?

@TitoGrine
Copy link

I prefer the "Need help" wording but I think it looks like a new tab and it might be odd to open a modal when clicked... I don't find a better place to have it. Maybe we can keep the placement but change the wording?

Yeah, I see what you mean, it does look a bit odd next to the tab. Last suggestion, do you feel it looks better aligned to the right? I think I prefer it, but I want your opinion @mivasconcelos @sandeshvijayraj

Screenshot from 2023-03-22 12-45-27

@sandeshvijayraj
Copy link
Contributor Author

sandeshvijayraj commented Mar 22, 2023

I prefer the "Need help" wording but I think it looks like a new tab and it might be odd to open a modal when clicked... I don't find a better place to have it. Maybe we can keep the placement but change the wording?

@TitoGrine
My personal opinion is both look great (I also liked the right aligned) but had a little investigation into how others are doing it.

What I observed was, in many of the UI such options are centre aligned or left-aligned. They have the option on the right only if there is another option on the left. It's not always but I see in most cases

Considering the fact, I would prefer to go with how it generally is which should be good as it doesn't make a big impact

@mivasconcelos
Copy link
Contributor

I prefer the "Need help" wording but I think it looks like a new tab and it might be odd to open a modal when clicked... I don't find a better place to have it. Maybe we can keep the placement but change the wording?

@TitoGrine My personal opinion is both look great (I also liked the right aligned) but had a little investigation into how others are doing it.

What I observed was, in many of the UI such options are centre aligned or left-aligned. They have the option on the right only if there is another option on the left. It's not always but I see in most cases

Considering the fact, I would prefer to go with how it generally is which should be good as it doesn't make a big impact

no strong opinion either. I would go with the designed approach but the changed wording

@sandeshvijayraj
Copy link
Contributor Author

sandeshvijayraj commented Mar 22, 2023

no strong opinion either. I would go with the designed approach but the changed wording

Ya, I like "Need help?" I will be making this change

web/src/components/HowItWorksModal.tsx Outdated Show resolved Hide resolved
web/src/components/HowItWorksModal.tsx Outdated Show resolved Hide resolved
>
<Stack justifyContent="center" alignItems="center" gap="26px">
<ModalHeader fontSize="26px" fontWeight="bold" padding="8px">
How Real-Time Digital marketing app works?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. What about: "How to connect to the Real-Time Digital marketing app?"

.gitignore Show resolved Hide resolved
Copy link

@TitoGrine TitoGrine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit, but everything else looks good.

Awesome work 🎉

@sandeshvijayraj sandeshvijayraj merged commit 0d91bd0 into main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants