-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to connect to Portal workspace automatically #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments
Note, any changes to RTDM must be backwards compatible with vapor and manual configuration. Hence why I need you to follow how the vapor config works. You will also need to check to see if there is a portalConfig in |
d86d489
to
e8b1eb1
Compare
d5daf0a
to
4d44491
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed comment
It doesn't appear that my previous comments have been addressed in the current state of this diff. |
You are missing updating the part of the app that checks for vaporConnectionConfig to change how the UI looks (to show that the connection is already configured). See my comment above:
|
I don't think we want to change how the UI looks - at least for now. We should keep it how it is. I believe it's ok to show the connection form. The design team is working on a new UI for this app though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create an updated loom of this flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks solid. Nice job
This logic aims to integrate this app with Portal and connect them automatically.
[Portal] user clicks on "go to application"
[Portal] it's created a custom user to be used on the RTDM app
[RTDM] extracts hostname and credentials from the URL
[RTDM] establishes a connection automatically with those values
https://www.loom.com/share/428a049fb7b64302affdf1bdc10e4181
cc: @davidgomes