Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Plumb old-style contexts to new libtiledbsoma contexts #3252

Merged

Conversation

mojaveazure
Copy link
Member

Allow plumbing tiledb-r contexts SOMATileDBContext objects into libtiledbsoma soma_context() objects

Modified SOMA methods:

  • TileDBObject$new(): plumb tiledbsoma_ctx config options into soma_context() when provided

SC-56531
addresses #3213

@johnkerl johnkerl changed the title [r] Plumb old-style contexts to new libtiledbsoma contexts [r] Plumb old-style contexts to new libtiledbsoma contexts Oct 29, 2024
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified good on my laptop with no AWS environment variables set

mojaveazure and others added 3 commits October 29, 2024 17:31
Allow plumbing tiledb-r contexts `SOMATileDBContext` objects into
libtiledbsoma `soma_context()` objects

Modified SOMA methods:
 - `TileDBObject$new()`: plumb `tiledbsoma_ctx` config options into
   `soma_context()` when provided

[SC-56531](https://app.shortcut.com/tiledb-inc/story/56531)
addresses #3213
Bump develop version
@mojaveazure mojaveazure force-pushed the paulhoffman/sc-56531/fix-cloud-region-issue-in-tiledb-soma-r branch from b2e28c5 to 793df4f Compare October 29, 2024 21:32
@johnkerl johnkerl merged commit 467af01 into main Oct 29, 2024
14 checks passed
@johnkerl johnkerl deleted the paulhoffman/sc-56531/fix-cloud-region-issue-in-tiledb-soma-r branch October 29, 2024 21:59
Copy link

The backport to release-1.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.15 release-1.15
# Navigate to the new working tree
cd .worktrees/backport-release-1.15
# Create a new branch
git switch --create backport-3252-to-release-1.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 467af019d7c7ec970de97d84c6d32d0903ff7148
# Push it to GitHub
git push --set-upstream origin backport-3252-to-release-1.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.15

Then, create a pull request where the base branch is release-1.15 and the compare/head branch is backport-3252-to-release-1.15.

johnkerl added a commit that referenced this pull request Oct 29, 2024
@johnkerl
Copy link
Member

Manual backport on #3257

The automated backport failed because of apis/r/DESCRIPTION and apis/r/NEWS.md (as one would expect)

johnkerl added a commit that referenced this pull request Oct 29, 2024
* [r] Prepare for 1.15.0rc3

* backport #3252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants