[c++] WKB geometry utilities #3149
Conversation
Move template function implementation outside of header files
XanthosXanthopoulos
force-pushed
the
xan/geometry_utils
branch
from
f75c159
to
ed46ad2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
==========================================
+ Coverage 83.05% 83.30% +0.25%
==========================================
Files 50 51 +1
Lines 5198 5458 +260
==========================================
+ Hits 4317 4547 +230
- Misses 881 911 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
XanthosXanthopoulos
changed the title
There was a problem hiding this comment.
This PR is large, but very clean. I added a couple of inline comments to the review. In addition:
-
For the tests, we should (1) make it easy to add in additional tests for each type, (2) add in additional tests for different edge cases for the geometries and (3) add tests for reading and erroring out on improperly formatted and/or unsupported WKB types. None of this needs to be added to this PR, but we should at least add stories to address this in the future.
-
Optional: I think we should move
libtiledbsoma/src/utils/geometryto justlibtiledbsoma/src/geometry.
|
|
||
| namespace tiledbsoma::geometry { | ||
|
|
||
| enum class GeometryType { |
There was a problem hiding this comment.
It looks like this matches the integer codes in the WKB spec.
- What do you think about making this a uint32_t enum to match the spec?
- Should we specify 2D on these types in case we want to add in 3D/4D versions as well?
Address PR comments
This PR adds a basic implementation for reading and writing geometry object from and to WKB buffers.