[python] Fix MultiscaleImage.read_spatial_region full region read
#3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `read_spatial_region` method should be able to accept `None` for a region. When this is provided, the whole array is returned.
johnkerl
approved these changes
Oct 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
==========================================
+ Coverage 81.93% 82.60% +0.67%
==========================================
Files 50 50
Lines 5198 5204 +6
==========================================
+ Hits 4259 4299 +40
+ Misses 939 905 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
MultiscaleImage.read_spatial_region full region read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
read_spatial_regionmethod should be able to acceptNonefor a region. When this is provided, the whole array is returned.