Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++/python] Address C++ warnings in Python build #2581

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented May 17, 2024

Issue and/or context: #2513

Changes:

  1. Add TILEDB_REMOVE_DEPRECATIONS as a CMake option that can be passed to the external TileDB build.
  2. Update CI to build TileDB without the deprecated API.
  3. Address a few misc. warnings in PyBind.
    • Use is instead of == for PyBind type checks.
    • Use TileDBSOMAPyError instead of TileDBSOMAError when generating errors in query_conditions.cc (remove redefinition).
    • Remove unused variables.

@jp-dark jp-dark marked this pull request as draft May 17, 2024 20:03
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (12566dd) to head (acb1999).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2581   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files          37       37           
  Lines        4007     4007           
=======================================
  Hits         3617     3617           
  Misses        390      390           
Flag Coverage Δ
python 90.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.26% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

* Rename new `bld` flag 'allow-tiledb-dep' with 'no-tiledb-deprecated'
* Add flag for disabling the deprecated API to `bld.ps1`
@jp-dark
Copy link
Collaborator Author

jp-dark commented May 20, 2024

Note: This change removes the TileDB deprecation warnings from some but not most CI. When TileDB is built downstream (e.g. as part of TileDB-Py), then the deprecations are still built into the API.

@jp-dark jp-dark marked this pull request as ready for review May 20, 2024 18:10
@jp-dark jp-dark requested a review from johnkerl May 20, 2024 18:10
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jp-dark jp-dark merged commit 12a41ab into main May 21, 2024
26 checks passed
@jp-dark jp-dark deleted the dark/sc-46757 branch May 21, 2024 18:32
github-actions bot pushed a commit that referenced this pull request May 21, 2024
1. Add `TILEDB_REMOVE_DEPRECATIONS` as a CMake option that can be passed to the external TileDB build.
2. Update CI to build TileDB without the deprecated API.
3. Address a few misc. warnings in PyBind. 
   * Use `is` instead of `==` for PyBind type checks.
   * Use `TileDBSOMAPyError` instead of `TileDBSOMAError` when generating errors in `query_conditions.cc` (remove redefinition).
   * Remove unused variables.

Note: This PR does not prevent deprecated warnings in all CI. If TileDB is built downstream or downloaded, the deprecated API will still be included.
johnkerl pushed a commit that referenced this pull request May 21, 2024
1. Add `TILEDB_REMOVE_DEPRECATIONS` as a CMake option that can be passed to the external TileDB build.
2. Update CI to build TileDB without the deprecated API.
3. Address a few misc. warnings in PyBind. 
   * Use `is` instead of `==` for PyBind type checks.
   * Use `TileDBSOMAPyError` instead of `TileDBSOMAError` when generating errors in `query_conditions.cc` (remove redefinition).
   * Remove unused variables.

Note: This PR does not prevent deprecated warnings in all CI. If TileDB is built downstream or downloaded, the deprecated API will still be included.

Co-authored-by: Julia Dark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants