[c++/python] Address C++ warnings in Python build #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
=======================================
Coverage 90.26% 90.26%
=======================================
Files 37 37
Lines 4007 4007
=======================================
Hits 3617 3617
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* Rename new `bld` flag 'allow-tiledb-dep' with 'no-tiledb-deprecated' * Add flag for disabling the deprecated API to `bld.ps1`
|
Note: This change removes the TileDB deprecation warnings from some but not most CI. When TileDB is built downstream (e.g. as part of TileDB-Py), then the deprecations are still built into the API. |
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2024
1. Add `TILEDB_REMOVE_DEPRECATIONS` as a CMake option that can be passed to the external TileDB build. 2. Update CI to build TileDB without the deprecated API. 3. Address a few misc. warnings in PyBind. * Use `is` instead of `==` for PyBind type checks. * Use `TileDBSOMAPyError` instead of `TileDBSOMAError` when generating errors in `query_conditions.cc` (remove redefinition). * Remove unused variables. Note: This PR does not prevent deprecated warnings in all CI. If TileDB is built downstream or downloaded, the deprecated API will still be included.
johnkerl
pushed a commit
that referenced
this pull request
May 21, 2024
1. Add `TILEDB_REMOVE_DEPRECATIONS` as a CMake option that can be passed to the external TileDB build. 2. Update CI to build TileDB without the deprecated API. 3. Address a few misc. warnings in PyBind. * Use `is` instead of `==` for PyBind type checks. * Use `TileDBSOMAPyError` instead of `TileDBSOMAError` when generating errors in `query_conditions.cc` (remove redefinition). * Remove unused variables. Note: This PR does not prevent deprecated warnings in all CI. If TileDB is built downstream or downloaded, the deprecated API will still be included. Co-authored-by: Julia Dark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: #2513
Changes:
TILEDB_REMOVE_DEPRECATIONSas a CMake option that can be passed to the external TileDB build.isinstead of==for PyBind type checks.TileDBSOMAPyErrorinstead ofTileDBSOMAErrorwhen generating errors inquery_conditions.cc(remove redefinition).