Update the MultiscaleImage API #238
Draft
+84
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-dark
commented
Oct 22, 2024
Comment on lines
-716
to
-734
| class ImageProperties(Protocol): | ||
| """Class requirements for level properties of images. | ||
|
|
||
| Lifecycle: experimental | ||
| """ | ||
|
|
||
| @property | ||
| def name(self) -> str: | ||
| """The key for the image. | ||
|
|
||
| Lifecycle: experimental | ||
| """ | ||
|
|
||
| @property | ||
| def shape(self) -> Tuple[int, ...]: | ||
| """Size of each axis of the image. | ||
|
|
||
| Lifecycle: experimental | ||
| """ |
There was a problem hiding this comment.
This class didn't add much value as is. We may want to expand it to include more information or just remove it altogether.
jp-dark
commented
Oct 22, 2024
python-spec/src/somacore/spatial.py
Outdated
| coordinate_space: Union[Sequence[str], coordinates.CoordinateSpace] = ( | ||
| "x", | ||
| "y", | ||
| ), | ||
| axis_types: Sequence[str] = ("channel", "height", "width"), |
There was a problem hiding this comment.
Is there a better name or better argument to take to distinguish between the on disk data order and the coordinate space?
jp-dark
requested review from
aaronwolen,
ihnorton,
johnkerl,
ktsitsi and
ivirshup
and removed request for
ihnorton
* Remove ``axis_type`` parameter from ``create`` * Add parameters to specify initial Image URI. * Add ``data_axis_order`` to ``create`` and ``read_spatial_region``.
* Fix DenseNDArray types to be _DenseND * Add return type for the new `set` methods * Add `data_axis_order` property * Add `has_channel_axis` property * Add `nchannel` property * Fix docstring for `level_shape`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress. The goal is to simplify/improve the MultiscaleImage API.