Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backticks et al. consistent in the abstract spec #127

Merged
merged 9 commits into from
Feb 16, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Feb 14, 2023

Context: #120

Basic copy-editing:

  • Make use of backticking consistent -- it was mixed on/off even in the same sentence
  • Uniformize -, --, and : to :
  • Uniformize periods at ends of sentences
  • Correctly spell i.e. and e.g.
  • Etc.

Reviewer-friendly rendering:
https://github.com/single-cell-data/SOMA/blob/kerl/backticks-et-al/abstract_specification.md

@johnkerl johnkerl force-pushed the kerl/backticks-et-al branch 8 times, most recently from 4c91567 to 3c9213b Compare February 15, 2023 02:33
@johnkerl johnkerl changed the title Make backticks et al. consistent in the abstract spec [WIP / please do not review] Make backticks et al. consistent in the abstract spec Feb 15, 2023
@johnkerl johnkerl marked this pull request as ready for review February 15, 2023 04:36
@johnkerl
Copy link
Member Author

@thetorpedodog @bkmartinjr ping 🙏

abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Show resolved Hide resolved
Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good, and I am greatly appreciative to @johnkerl for the work on this.

My only concern is the ability to use automated reformatting in the future, and the newly introduced use of github extensions (for list, i.e., asterisk instead of dash). If we can find and configure a single reformatter for all of our markdown, and configure it for asterisk, I'm fine with the change. Else I recommend reverting back to baseline standard markdown (which is the default for most formatters, or at least the one I use :-)).

Happy to approve as soon as we have a plan on this issue.

@johnkerl
Copy link
Member Author

@bkmartinjr on my commits after your feedback I ran prettier abstract_specification.md and, as noted, reverted * bullets to - bullets.

@bkmartinjr
Copy link
Member

@johnkerl - lets codify the formatting conventions (i.e., we use "tool X" with "Y config" somewhere).

@johnkerl
Copy link
Member Author

@bkmartinjr thanks!

What does "codify" mean to you in terms of an actionable step?

  • I update the wiki for this repo asking people to use it
  • I update the pre-commit logic for this repo (automating it)
  • Or something else?

@bkmartinjr
Copy link
Member

What does "codify" mean to you in terms of an actionable step?

Ideally we should have a CI check it. But that is nice-to-have. I'd settle for "write it down in a conventions doc" for now, and we can CI stuff like this at a later date.

Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY John!

@johnkerl
Copy link
Member Author

Ideally we should have a CI check it. But that is nice-to-have. I'd settle for "write it down in a conventions doc" for now, and we can CI stuff like this at a later date.

Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the en dash requester has logged on

abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
abstract_specification.md Show resolved Hide resolved
abstract_specification.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, all of these are really trivia and it is still an improvement over the existing text and formatting.

@johnkerl johnkerl merged commit f5d76ce into main Feb 16, 2023
@johnkerl johnkerl deleted the kerl/backticks-et-al branch February 16, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants