improves promo codes (#225)

sinfo · Apr 10, 2024 · 0c1b6a0 · 0c1b6a0
1 parent 7653900
commit 0c1b6a0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/server/db/promo-code.js b/server/db/promo-code.js
@@ -3,7 +3,10 @@ const mongoose = require('mongoose')
 const schema = new mongoose.Schema({
   company: String,
   edition: String,
-  expire: Date,
+  validity: {
+    from: Date,
+    to: Date
+  },
   description: String,
   code: String
 })

diff --git a/server/resources/promo-code.js b/server/resources/promo-code.js
@@ -8,8 +8,13 @@ server.method('promoCode.get', get, {})
 async function get () {
   let now = new Date()
 
+  filter = {
+    'validity.from': { $lte: now },
+    'validity.to': { $gte: now }
+  }
+
   try {
-    let codes = await PromoCode.find({ expire: { '$gt': now.toISOString() } }, {}, {})
+    let codes = await PromoCode.find(filter)
     if (!codes) {
       log.warn({ err: err }, 'could not find promo code')
       return cb(Boom.notFound())

diff --git a/server/views/promo-code.js b/server/views/promo-code.js
@@ -10,7 +10,7 @@ function renderObject (model) {
   return {
     company: model.company,
     edition: model.edition,
-    expire: model.expire,
+    expire: model.validity.to,
     description: model.description,
     code: model.code
   }