Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix array query params #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yenh-cs
Copy link

@yenh-cs yenh-cs commented Apr 21, 2023

No description provided.

@yenh-cs yenh-cs force-pushed the fix_array_query_params branch from 35bf04e to d8bc887 Compare April 21, 2023 04:55
@sinedied
Copy link
Owner

Thanks for your PR, and sorry for taking so long to answer.
I took some time to look into this, and honestly I'm not sure what would be the best way to have array params parsing.

The solution you provided works for some languages/framework (PHP or Node.js for example) but not is invalid for some others (.Net), and there's no standard way of parsing array params. There's lot of example in this discussion here: https://stackoverflow.com/questions/6243051/how-to-pass-an-array-within-a-query-string

You proposal might be a good default behavior though, but before merging it I would like to find a way to support others methods of array parsing as an option (probably only when using JS mocks) to supports the cases when the proposed solution will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants