-
-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sui & Update Move #3274
base: main
Are you sure you want to change the base?
Add Sui & Update Move #3274
Conversation
It's weird to click a link called "Move" and end up on a list called "Sui". The relation to "Move" needs to be made clearer in the list. |
Yeh, Move is a generic language, and the library(package) is platform specific. I specify the term |
Hi @Cremetruck Thanks for review. |
Not a requirement, but I suggest linkifying Sui in the readme to point to the official website and updating the repo description to focus on Sui instead of Move. Looks great otherwise. Good job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to change the title of the PR to follow the standard
"Add [topic]", i.e. "Add Sui".
This pull request has a title in the format Add Name of List.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't attentive enough in my first review where I suggested to change the name. I only now realize your PR contains two unrelated changes. So I suggest to split it up into two:
- Add Sui
- Update Move (or "change link for move"
In the second, you should explain why the new link is better / more relevant than the old.
"current one from MystenLabs will be deprecated, and Sui Foundation will take care about this in the future." This is already in the top section of PR description. We work really closely, and the foundation take over and keep maintaining ecosystem facing tasks, so there is less distracting things for MystenLabs. Also, just wonder if we can do thing in one PR clearly and efficiently why we do two. Because move is become one section, and it needs library and platform. I believe one PR is good here. If you think we need extra 2 pr reviews for this PR, I am happy to do so, but split PR will easy to make thing in a mess and wast community energy. I hope you can kindly understand. |
@sindresorhus Does this PR good to merge? |
https://github.com/sui-foundation/awesome-sui
Move is a programming language for writing safe smart contracts originally developed at Facebook in 2019 as part of the Diem project, and it is active and keep maintained now. We update the link of awesome-move, because current one from MystenLabs will be deprecated, and Sui Foundation will take care about this in the future.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Add F# #3259 (review)
Add Yazi #3232 (review)
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.