Drop sentry async job submission - use Sentry's builtin background worker #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See getsentry/sentry-ruby#1522 for details and why we want to do this change. We suspect this also may be a cause of https://app.shortcut.com/simpledotorg/story/5282/redis-down-in-production
|
This pull request has been linked to Shortcut Story #5288: Change Sentry to use its own built in async job submission instead of Sidekiq. |
kpethtel
approved these changes
Sep 28, 2021
We are using Datadog for tracing currently, and having two tools capturing trace info is not necessary and may add some overhead we don't want..
This reverts commit e1eae44.
|
Verified with our error tracing available in the admin panel from sandbox and the review app. https://sentry.io/organizations/resolve-to-save-lives/issues/2680093534/?project=1217715&query=is%3Aunresolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry has had its own backgrounb job submissions done via concurrent-ruby since version 4.1. We have been using the
asyncconfig option for a long time to send jobs through Sidekiq, which has quite a bit overhead and also introduces another point of failure for error submission.This PR removes the
asyncoption so that Sentry will just use its own background thread for job processing.See getsentry/sentry-ruby#1522 for more details about this and why we want to do this change, as its possible the
asyncoption may be removed entirely in sentry-ruby version 5.We suspect this also may be a cause of https://app.shortcut.com/simpledotorg/story/5282/redis-down-in-production
Story card: ch5288