Pull starting slice from redis instead of extrapolating #154

sbwdlihao · 2014-10-31T12:16:51Z

start index may be not exist when chain first join or rejoin in mine

coveralls · 2014-10-31T12:19:53Z

Coverage increased (+0.01%) when pulling 1c51806 on sbwdlihao:patch-3 into 50ceb67 on simplecrypto:master.

icook · 2014-11-02T02:31:51Z

simplecoin/scheduler.py

@@ -569,8 +571,10 @@ def credit_block(redis_key, simulate=False):
    for id, chain in chain_data.iteritems():
        if chain['shares'] == 0:
            continue
+        start_slice = chain['start_index'] if chain.has_key('start_index') else chain['solve_index'] - 1


I'm unsure about the correctness of this. In scenarios involving merge-mined blocks this will definitely be wrong at certain times. Effectively, something can occur where "slice 0" has most of the shares, and was rotated by a merge mined block solve. "slice 1" has a small number of shares, and was rotated due to a main network block solve.

The simplest fix is to require the "start_index" value if there are other blocks solved on the same chain already. This has it's own problems tho if the redis database gets wiped.

I'll keep thinking on this. For the large majority of cases tho this should work fine. Thanks for the work!

sbwdlihao added 3 commits October 31, 2014 20:07

Update config.py

62f13a5

Update models.py

08388fc

Update scheduler.py

1c51806

start index may be not exist when chain first join or rejoin in mine

sbwdlihao mentioned this pull request Oct 31, 2014

Update scheduler.py #146

Closed

icook reviewed Nov 2, 2014
View reviewed changes

icook changed the title ~~Patch 3~~ Pull starting slice from redis instead of extrapolating Nov 6, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pull starting slice from redis instead of extrapolating #154

Pull starting slice from redis instead of extrapolating #154

sbwdlihao commented Oct 31, 2014

coveralls commented Oct 31, 2014

icook Nov 2, 2014

Pull starting slice from redis instead of extrapolating #154

Are you sure you want to change the base?

Pull starting slice from redis instead of extrapolating #154

Conversation

sbwdlihao commented Oct 31, 2014

coveralls commented Oct 31, 2014

icook Nov 2, 2014

Choose a reason for hiding this comment