Fix docker installation #401
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesar-richard
requested changes
Sep 29, 2022
Comment on lines
+10
to
+15
| DB_CONNECTION=mysql | ||
| DB_HOST=database | ||
| DB_PORT=3306 | ||
| DB_DATABASE=portail | ||
| DB_USERNAME=portail | ||
| DB_PASSWORD=portail |
There was a problem hiding this comment.
Pourquoi ? C'est des valeurs fixes car uniquement utilisées pour du dev local, pas besoin de les modifier. Elles devraient rester en dur dans le docker-compose
There was a problem hiding this comment.
Je crois que c'est un paramètre qu'il faut préciser à la fois sous cette forme pour le portail…
There was a problem hiding this comment.
Je peux mettre celui-ci dans docker-compose aussi stu veux
docker-compose.yml
Outdated
Comment on lines
54
to
57
| - MYSQL_ROOT_PASSWORD=portail | ||
| - MYSQL_USER=portail | ||
| - MYSQL_PASSWORD=portail | ||
| - MYSQL_DATABASE=portail |
There was a problem hiding this comment.
CF les ENV plus haut, en plus ca n'a pas l'air utilisé, si ?
There was a problem hiding this comment.
… et sous celui-ci pour mysql.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All those steps and tweaks permit to have a working Docker installation out of the box, following the (updated) documentation instructions.²