Rearange assos sidebar and hide career (fixing #331) #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be ready to merge now ! |
|
Okay, I'll test it this evening. I'm also modifying the seeders to create followed assos, followed services and joining members! |
There was a problem hiding this comment.
It works but you changed the Asso/MemberController and it is not used in this case. Why?
Is it to fix #322 ?
|
Yes, this commit was a first step for #322 but it seems like I messed up with my branches ... This fix is usefull anyway, but not related to this PR. |
|
As we need history to be clean in order to search easier modifications' justifications could you cherry-pick your first commit to another branch and delete it from this branch? |
noeamiot
force-pushed
the
feature/rearange-assos-sidebar-and-hide-career
branch
from
89b0545
to
becb3d8
Compare
MercierCorentin
approved these changes
Mar 6, 2020
MercierCorentin
deleted the
feature/rearange-assos-sidebar-and-hide-career
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.