New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix unit test #603

Merged

emteknetnz merged 1 commit into silverstripe:4 from creative-commoners:pulls/4/fix-tests

Sep 30, 2024

Member

GuySartorelli commented Sep 30, 2024

Fixes https://github.com/silverstripe/silverstripe-subsites/actions/runs/11061581662/job/30829569214

SilverStripe\Subsites\Tests\Service\ThemeResolverTest::testCustomThemeDefinitionsAreRespected
The data provider specified for SilverStripe\Subsites\Tests\Service\ThemeResolverTest::testCustomThemeDefinitionsAreRespected is invalid
Using $this when not in object context

Issue

Broken builds and merge-ups .github#313


          MNT Fix unit test

GuySartorelli mentioned this pull request

Broken builds and merge-ups silverstripe/.github#313

Closed

emteknetnz approved these changes

View reviewed changes

emteknetnz merged commit 3939401 into silverstripe:4

11 checks passed

emteknetnz deleted the pulls/4/fix-tests branch

September 30, 2024 05:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet