FIX Update CMS fields now that they're being scaffolded #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Aug 11, 2024
Comment on lines
-103
to
-134
| $fields->addFieldToTab( | ||
| 'Root.Main', | ||
| TextField::create( | ||
| 'CustomMetaTitle', | ||
| $this->fieldLabel('CustomMetaTitle') | ||
| )->setDescription(_t(__CLASS__ . '.OverrideNote', 'Overrides inherited value from the source')), | ||
| 'MetaTitle' | ||
| ); | ||
| $fields->addFieldToTab( | ||
| 'Root.Main', | ||
| TextareaField::create( | ||
| 'CustomMetaKeywords', | ||
| $this->fieldLabel('CustomMetaKeywords') | ||
| )->setDescription(_t(__CLASS__ . '.OverrideNote', 'Overrides inherited value from the source')), | ||
| 'MetaKeywords' | ||
| ); | ||
| $fields->addFieldToTab( | ||
| 'Root.Main', | ||
| TextareaField::create( | ||
| 'CustomMetaDescription', | ||
| $this->fieldLabel('CustomMetaDescription') | ||
| )->setDescription(_t(__CLASS__ . '.OverrideNote', 'Overrides inherited value from the source')), | ||
| 'MetaDescription' | ||
| ); | ||
| $fields->addFieldToTab( | ||
| 'Root.Main', | ||
| TextField::create( | ||
| 'CustomExtraMeta', | ||
| $this->fieldLabel('CustomExtraMeta') | ||
| )->setDescription(_t(__CLASS__ . '.OverrideNote', 'Overrides inherited value from the source')), | ||
| 'ExtraMeta' | ||
| ); |
There was a problem hiding this comment.
Moved the relevant ones to VirtualPage (see silverstripe/silverstripe-cms#2983)
Removed CustomMetaTitle and CustomMetaKeywords because the fields they're intended to override were long-since removed from SiteTree.
GuySartorelli
commented
Aug 11, 2024
Comment on lines
+52
to
+58
| $pageSelectionField = SubsitesTreeDropdownField::create( | ||
| 'CopyContentFromID', | ||
| _t('SilverStripe\\CMS\\Model\\VirtualPage.CHOOSE', 'Linked Page'), | ||
| SiteTree::class, | ||
| 'ID', | ||
| 'MenuTitle' | ||
| ); |
There was a problem hiding this comment.
This field is moved to the top which is right next to the subsite selector field and matches where it sits in the normal virtual page.
GuySartorelli
force-pushed
the
pulls/4/scaffold-sitetree
branch
from
467ccb8
to
16b890f
Compare
|
CI failures should go green when other PRs are merged (see kitchen sink CI run) |
emteknetnz
approved these changes
Aug 13, 2024
emteknetnz
requested changes
Aug 15, 2024
|
Fingers crossed it just needs a rebase. |
GuySartorelli
force-pushed
the
pulls/4/scaffold-sitetree
branch
from
16b890f
to
21ad49a
Compare
emteknetnz
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on changes to
SiteTreeandVirtualPagein silverstripe/silverstripe-cms#2983Issue