Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Take advantage of auto-scaffolded form fields #581

Merged
merged 1 commit into from
Jun 26, 2024
Merged

ENH Take advantage of auto-scaffolded form fields #581

merged 1 commit into from
Jun 26, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli
Copy link
Member Author

JS CI failure is unrelated to these changes

@GuySartorelli GuySartorelli mentioned this pull request Jun 19, 2024
Closed
6 tasks
emteknetnz
emteknetnz requested changes Jun 20, 2024
View reviewed changes
src/Model/Subsite.php Show resolved Hide resolved
emteknetnz
emteknetnz approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works well

Failing JS test is unrelated

@emteknetnz emteknetnz merged commit d1acb20 into silverstripe:4 Jun 26, 2024
11 of 12 checks passed
@emteknetnz emteknetnz deleted the pulls/4/scaffolded-fields branch June 26, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz