Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/trigger in dataextensions #214

Merged

Conversation

tiller1010
Copy link
Contributor

@tiller1010 tiller1010 commented Jan 10, 2025

Description

Allows StaticPublishingTrigger to be added in DataExtensions

Manual testing steps

  • Add a DataExtension to a DataObject without StaticPublishingTrigger
  • Also add the SiteTreePublishingEngine extension to that DataObject
  • Confirm the instances of the DataObject have their URLs queued to be cached when saved/published

Issues

Closes #211

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli
Copy link
Member

Can you please check all the boxes that apply in the PR checklist? That checklist is there so that you as the contributor can make sure you're doing things correctly before this gets reviewed. For example the commit message doesn't follow the guidelines.

src/Dev/DataExtensionAddsTrigger.php Outdated Show resolved Hide resolved
src/Dev/DataExtensionAddsTrigger.php Outdated Show resolved Hide resolved
src/Dev/DataExtensionAddsTrigger.php Outdated Show resolved Hide resolved
src/Dev/DataObjectNoTrigger.php Outdated Show resolved Hide resolved
src/Extension/Engine/SiteTreePublishingEngine.php Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli self-assigned this Jan 15, 2025
- Replace DataExtension with Extension
- Used create instead of fixture entry in test
- Simplified engine extension check
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for providing this improvement.
I'll fix up the commit message on merge.

@GuySartorelli GuySartorelli merged commit 5c0fda7 into silverstripe:6 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow StaticPublishingTrigger to be added in DataExtensions
2 participants