-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/trigger in dataextensions #214
Feature/trigger in dataextensions #214
Conversation
Can you please check all the boxes that apply in the PR checklist? That checklist is there so that you as the contributor can make sure you're doing things correctly before this gets reviewed. For example the commit message doesn't follow the guidelines. |
- Replace DataExtension with Extension - Used create instead of fixture entry in test - Simplified engine extension check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for providing this improvement.
I'll fix up the commit message on merge.
Description
Allows StaticPublishingTrigger to be added in DataExtensions
Manual testing steps
Issues
Closes #211
Pull request checklist