Add title, classes, and icon for action in saved version

[phalkunz]

Issue: silverstripe/silverstripe-campaign-admin#16

[tractorcow]

None of these methods describe what each of these are used for; They also seem to be very specific use cases baked into the generic form action class, which feels a little over-zealous.

You could generalise it, so you don't need so many extra methods into a saved state?

FormAction::create('save', _t(__CLASS__.'.SAVE', 'Save'))
    ->setIcon('save')
    ->setSavedState([
    	'title' => _t(__CLASS__.'.SAVED', 'Saved'),
    	'icon' => 'tick',
    	'extraClass' => 'primary-outline',
   	]);

and in js

getProps() {
	let props = Object.assign({}, this.props, this.props.data);
	if (!this.changed) {
		props = Object.assign({}, this.props.data.savedState);
	}
	return props;
}

Or something :P

[phalkunz]

@tractorcow Thanks :) Will fix it now

[flamerohr]

I don't recommend mixing this.props and this.props.data like that getProps() suggestion... then the this.props.data.savedState for the changed condition makes it even worse to debug with.
if the data cannot be clearly discovered in a given path and needs to be explored in multiple areas, maybe the API needs to be re-assessed.

[tractorcow]

For context, this is what we do in SiteTree at the moment (entwine styles)

FormAction::create('save', _t(__CLASS__.'.BUTTONSAVED', 'Saved'))
                    ->addExtraClass('btn-secondary-outline font-icon-check-mark')
                    ->setAttribute('data-btn-alternate', 'btn action btn-primary font-icon-save')
                    ->setUseButtonTag(true)
                    ->setAttribute('data-text-alternate', _t('SilverStripe\\CMS\\Controllers\\CMSMain.SAVEDRAFT', 'Save draft'))

[flamerohr]

Closing, as the issue has been solved