BUG include silverstripe core files into roots

silverstripe · Aug 1, 2023 · 359cb14 · 359cb14
1 parent d9f40a2
commit 359cb14
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Core/Manifest/ClassManifest.php b/src/Core/Manifest/ClassManifest.php
@@ -650,6 +650,11 @@ public function handleFile($basename, $pathname, $includeTests)
                     }
                     $this->children[$lowerAncestor][$lowerClassName] = $className;
                 }
+
+                // If the class extends a core class, add class to roots
+                if (strpos($ancestor, 'SilverStripe\\Control') === 0) {
+                    $this->roots[$lowerAncestor] = $ancestor;
+                }
             } else {
                 $this->roots[$lowerClassName] = $className;
             }

diff --git a/tests/php/Core/ClassInfoTest.php b/tests/php/Core/ClassInfoTest.php
@@ -87,6 +87,14 @@ public function testSubclassesFor()
             $subclassesWithoutBase,
             ClassInfo::subclassesFor('silverstripe\\core\\tests\\classinfotest\\baseclass', false)
         );
+
+        // Check that core classes are present (eg: Email subclasses)
+        $emailClasses = ClassInfo::subclassesFor(\SilverStripe\Control\Email\Email::class);
+        $this->assertArrayHasKey(
+            'silverstripe\\control\\tests\\email\\emailtest\\emailsubclass',
+            $emailClasses,
+            'It contains : ' . json_encode($emailClasses)
+        );
     }
 
     public function testClassName()