API Strong typing for the view layer #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
23 tasks
GuySartorelli
commented
Aug 22, 2024
Comment on lines
+604
to
+612
| public function forTemplate($holder = true): string | ||
| { | ||
| $templates = $this->getRenderTemplates(); | ||
|
|
||
| if ($templates) { | ||
| return $this->renderWith($templates); | ||
| } | ||
|
|
||
| return null; | ||
| return ''; |
There was a problem hiding this comment.
There's no parent class enforcing non-nullable values yet - but part of the next piece of work will include adding forTemplate() directly on ViewableData where its return type will be string.
There's just no reason for this method to ever return null, in comparison with an empty string.
GuySartorelli
force-pushed
the
pulls/6/strong-typing
branch
from
b954e7d
to
7e0b590
Compare
emteknetnz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want a good base of known types for things that will be going into the template layer before I start abstracting it, and this gets me part of the way there.
Issue