Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Versioned badge to elements #1137

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Jan 26, 2024

Description

New badge element was added in the title to show current state of changes of Element block. There are three different bages:

  • Draft for unpublished changes in new blocks;
  • Modified for modified published blocks;

Manual testing steps

  • I create new Content Block in Elemental Area.
  • I should see Draft badge.
  • I populate Title field with "My title".
  • I should see Draft badge.
  • I save block.
  • I should see Draft badge.
  • I publish block.
  • I should not see a badge.
  • I update Title field.
  • I should see Modified badge.
  • I save block.
  • I should see Modified badge.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@sabina-talipova sabina-talipova force-pushed the pulls/5.1/title-versioned-badge branch 3 times, most recently from 4461d34 to 4eb3cba Compare January 28, 2024 20:52
@sabina-talipova sabina-talipova marked this pull request as ready for review January 28, 2024 21:07
@GuySartorelli
Copy link
Member

GuySartorelli commented Jan 28, 2024

@sabina-talipova I haven't looked at this beyond reading the PR description, but just double checking if you've checked with the design team about the blue dot state?

There's a blue "dirty state" dot that shows when editing a block. We are not sure if that should have a matching label. Please validate with UX team.

@sabina-talipova sabina-talipova force-pushed the pulls/5.1/title-versioned-badge branch from 4eb3cba to 32bf5b4 Compare January 28, 2024 23:24
@sabina-talipova sabina-talipova force-pushed the pulls/5.1/title-versioned-badge branch 2 times, most recently from 8f68372 to c465340 Compare January 29, 2024 19:49
@sabina-talipova
Copy link
Contributor Author

@sabina-talipova I haven't looked at this beyond reading the PR description, but just double checking if you've checked with the design team about the blue dot state?

There's a blue "dirty state" dot that shows when editing a block. We are not sure if that should have a matching label. Please validate with UX team.

Cassie suggested to remove "dirty state" and show only "Draft" or "Modified" status.

@sabina-talipova sabina-talipova force-pushed the pulls/5.1/title-versioned-badge branch from c465340 to 7091974 Compare January 29, 2024 20:43
@sabina-talipova sabina-talipova force-pushed the pulls/5.1/title-versioned-badge branch from 7091974 to 5c34f24 Compare January 29, 2024 20:44
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR. My only feedback would be to possibly increase the amount of padding to the left of the badge, though if design team is happy with it then so am I

Just to double check, have you gotten sign off from the design PR?

Could you also create a new card to remove any dead code relating to the now removed hover state

Also this should be targeting 5 instead of 5.1 since there's a slightly functionality change with the removal of the blue dot

@sabina-talipova
Copy link
Contributor Author

Very nice PR. My only feedback would be to possibly increase the amount of padding to the left of the badge, though if design team is happy with it then so am I

Just to double check, have you gotten sign off from the design PR?

I increased margin-left and checked with Cassie again that she is happy with current view and behaviour.

Could you also create a new card to remove any dead code relating to the now removed hover state

I have removed all related code and elements in this PR.

Also this should be targeting 5 instead of 5.1 since there's a slightly functionality change with the removal of the blue dot

I close this PR and open new one for branch 5

@sabina-talipova sabina-talipova deleted the pulls/5.1/title-versioned-badge branch January 29, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants