-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Versioned badge to elements #1137
ENH Versioned badge to elements #1137
Conversation
4461d34
to
4eb3cba
Compare
@sabina-talipova I haven't looked at this beyond reading the PR description, but just double checking if you've checked with the design team about the blue dot state?
|
4eb3cba
to
32bf5b4
Compare
8f68372
to
c465340
Compare
Cassie suggested to remove "dirty state" and show only "Draft" or "Modified" status. |
c465340
to
7091974
Compare
7091974
to
5c34f24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR. My only feedback would be to possibly increase the amount of padding to the left of the badge, though if design team is happy with it then so am I
Just to double check, have you gotten sign off from the design PR?
Could you also create a new card to remove any dead code relating to the now removed hover state
Also this should be targeting 5
instead of 5.1
since there's a slightly functionality change with the removal of the blue dot
I increased
I have removed all related code and elements in this PR.
I close this PR and open new one for branch 5 |
Description
New badge element was added in the title to show current state of changes of Element block. There are three different bages:
Draft
for unpublished changes in new blocks;Modified
for modified published blocks;Manual testing steps
Draft
badge.Draft
badge.Draft
badge.Modified
badge.Modified
badge.Issues
Pull request checklist