Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use symfony/validation logic #3009

Merged
merged 1 commit into from
Oct 2, 2024
Merged

ENH Use symfony/validation logic #3009

merged 1 commit into from
Oct 2, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli marked this pull request as draft September 24, 2024 05:46
@GuySartorelli GuySartorelli mentioned this pull request Sep 24, 2024
Closed
3 tasks
@GuySartorelli GuySartorelli marked this pull request as ready for review September 24, 2024 22:29
emteknetnz
emteknetnz requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behat failure

@GuySartorelli
Copy link
Member Author

Oops, I somehow missed a reference to the old PasswordValidator.
Should be fixed by silverstripe/silverstripe-behat-extension#286

@emteknetnz emteknetnz merged commit bd48b04 into silverstripe:6 Oct 2, 2024
14 checks passed
@emteknetnz emteknetnz deleted the pulls/6/symfony-validation branch October 2, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz