FIX Use renamed validate method #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
emteknetnz
force-pushed
the
pulls/3/fix-mergeup
branch
from
419a9fb
to
595d160
Compare
emteknetnz
force-pushed
the
pulls/3/fix-mergeup
branch
from
595d160
to
7adb495
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/3/fix-mergeup
branch
from
7adb495
to
7973a2d
Compare
|
The PR description says "the deprecated validate() method was removed on merge-up when it shouldn't have been" - i.e. the validate() method should not be removed? I assume you meant "it should have been removed in a follow-up PR instead of in a merge-up" but I just want to confirm before I merge this, since it's not completely clear. |
Yes that's correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11403
Note that the deprecated validate() method was removed on merge-up when it shouldn't have been