Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Update validation methods #648

Open
wants to merge 1 commit into
base: 3
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Storage/DBFile.php
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,9 @@ protected function assertFilenameValid(string $filename): void
/**
* Hook to validate this record against a validation result
*
* @param string $filename Optional filename to validate. If omitted, the current value is validated.
* @param null|string $filename Optional filename to validate. If omitted, the current value is validated.
*/
public function validateFilename(ValidationResult $result, $filename = null): bool
public function validateFilename(ValidationResult $result, ?string $filename = null): bool
{
if (empty($filename)) {
$filename = $this->getFilename();
Expand Down Expand Up @@ -494,7 +494,6 @@ public function setField(string $fieldName, mixed $value, bool $markChanged = tr
return parent::setField($fieldName, $value, $markChanged);
}


/**
* Returns the size of the file type in an appropriate format.
*
Expand Down