DEP Add league/flysystem-local to fix test #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/3/flysystem-deps
branch
from
a60956d
to
ff06575
Compare
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/3/flysystem-deps
branch
from
ff06575
to
f6d13b6
Compare
emteknetnz
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the changes to #644 weren't sufficient - I must have had a more recent version of
league/flysystem-localin my local while testing it.We need to add this as an explicit dependency because
league/flysystemhas a lower dependency against it than what we need. Note thatleague/flysystemalso had to be bumped, becauseleague/flysystem-localdoesn't work with lower versions of it (despite not declaring that in its constraints)See the changes added in that version which include changes to mimetype detection.
I ran this through asset admin CI this time around
Issue