BUG Add a status column to the table view #980
Conversation
maxime-rainville
force-pushed
the
pulls/1/status-on-table-view
branch
from
d00f13f
to
82a4b16
Compare
| * @param {object} props | ||
| * @returns {Component|null} | ||
| */ | ||
| renderStatus(props) { |
There was a problem hiding this comment.
This was inspired by getStatusFlags on GalleryItem.
getStatusFlags has a updateStatusFlags hook that looks like it's meant to allow module like Fluent to add their own status flags. However, it's not clear how you would go about using it or that it even works.
If allowing module to add their own flags is a key requirements, I think we need to rethink how this is done and come up with a consistent way of doing for both the gallery view and the table view.
|
|
||
| flags = flags.map(({ ...attributes }) => <VersionedBadge {...attributes} />); | ||
|
|
||
| return <span>{flags}</span>; |
There was a problem hiding this comment.
So this would return an empty span for folders - was that deliberate?
There was a problem hiding this comment.
I've updated it to return null when there's no flag. There's a possible future where we update this again so other module can specify their own flags and where someone decide they want to flag folders.
maxime-rainville
force-pushed
the
pulls/1/status-on-table-view
branch
from
871678d
to
e5f206b
Compare
|
LGTM, just gotta get the tests green @maxime-rainville |
The Table view didn't have a way to view the status of individual files.
Parent issue
Related PRs