Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add missing quote on route example #612

Closed

Conversation

catharsisjelly
Copy link

@catharsisjelly catharsisjelly commented Oct 25, 2024

Description

Found a missing quote in the documentation for routing

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

@catharsisjelly catharsisjelly changed the base branch from 5.3 to 5 October 25, 2024 15:08
@catharsisjelly catharsisjelly changed the title Routing quote fix DOC Routing quote fix Oct 25, 2024
@catharsisjelly catharsisjelly changed the title DOC Routing quote fix DOC Add missing quote on route example Oct 25, 2024
@catharsisjelly
Copy link
Author

catharsisjelly commented Oct 25, 2024

After reading the instructions I was not sure if I need to target 5.3 for this or not. I'm happy to rebase the change to 5.3 if needed

@GuySartorelli
Copy link
Member

Yes, please retarget this PR to 5.3 - otherwise the changes won't be seen until April.

@catharsisjelly
Copy link
Author

Somehow I messed this up and it auto-merged after I rebased I'll resubmit the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants