Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #610

Open
wants to merge 22 commits into
base: 5.3
Choose a base branch
from
Open

Patch 1 #610

wants to merge 22 commits into from

Conversation

MauritzFunke
Copy link

@MauritzFunke MauritzFunke commented Oct 25, 2024

Description

I didn't know how to edit existing shortcodes, clarified that in the corresponding documentation

Issues

Fixes https://forum.silverstripe.org/t/edit-htmleditor-image-template/9952

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

emteknetnz and others added 22 commits September 6, 2024 09:53
…eprecate-top-page-classes

DOC Deprecate TopPage classes that are being renamed
…archar-classname

DOC Changing ClassName from Enum to Varchar
…pi-depr

DOC Add validations related to DBField
@GuySartorelli
Copy link
Member

There are a lot more commits here than just the one with your change. Can you please update your pull request to only include the relevant commit?

These instructions may help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants