-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add importers and exporters #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Servers aren't ready immediately, so let's wait a bit and try again at a maximum of 10 times
it's a bit too much
…estroy child process
It's still not perfect... What happens if the program crashes? We have to restart the server
Abandon the idea of importing projects. Just create a new empty one and import your files if you want then.
Note that this fucks up when gradle 9 is released...
sillydan1
commented
Feb 6, 2024
core/src/main/java/dk/gtz/graphedit/spi/GrpcLanguageServer.java
Outdated
Show resolved
Hide resolved
graphedit/src/main/java/dk/gtz/graphedit/view/GraphEditApplication.java
Outdated
Show resolved
Hide resolved
...ain/java/dk/gtz/graphedit/plugins/syntaxes/petrinet/importing/tapaal/TapaalPNMLExporter.java
Show resolved
Hide resolved
sillydan1
force-pushed
the
bugfix/getting-grpc-to-work
branch
from
February 7, 2024 19:27
6cff46a
to
0b31d21
Compare
sillydan1
force-pushed
the
bugfix/getting-grpc-to-work
branch
from
February 8, 2024 06:05
0b31d21
to
8f9af98
Compare
I removed the check because gradle itself will complain about versions. While the default error is a bit obscurely formulated, it is easier to maintain when just relying on the tooling itself saying stuff like: version 65 is not compatible with java17.
sillydan1
commented
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing javadocs
Also, probably rename the PR to make the changelog a bit prettier. Especially since this is a minor version bump...
sillydan1
force-pushed
the
bugfix/getting-grpc-to-work
branch
from
February 18, 2024 16:58
4292374
to
5db98d6
Compare
sillydan1
changed the title
Bugfix/getting grpc to work
Feature: add importers and exporters
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.