-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from NPM to PNPM for package management #1818
Commits on May 24, 2024
-
Switch from NPM to PNPM as package tool
Advantage of PNPM is speed and storage size on disk: if you have multiple projects using the same NPM package, NPM will store multiple copies, but PNPM will store only one copy and share it between projects. Most recent version of PNPM also requires Node version 18 or later, so we'll bump any Node 16 references to most recent Node (22.2.0).
Configuration menu - View commit details
-
Copy full SHA for 9a6bf9b - Browse repository at this point
Copy the full SHA 9a6bf9bView commit details -
Don't copy node_modules from dev, run pnpm i in Docker
Also lets us remove the rebuild of node-sass, which was needed for devs running a different architecture on their dev machines than the architecture the Docker containers are built for (e.g. devs running Macs with ARM chips, when the Docker containers we build are for x64).
Configuration menu - View commit details
-
Copy full SHA for 70dc91d - Browse repository at this point
Copy the full SHA 70dc91dView commit details -
Bump version of date-fns to fix build error
Version 2 of date-fns had some assumptions built into the package about the layout of node_modules that aren't true when pnpm is managing it. Version 3 of date-fns fixed those assumptions.
Configuration menu - View commit details
-
Copy full SHA for f5788f3 - Browse repository at this point
Copy the full SHA f5788f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d25eea2 - Browse repository at this point
Copy the full SHA d25eea2View commit details -
Use build targets to reduce unneeded builds
By specifying `target: development` in docekr-compose.yml, we get the same effect as specifying `docker build --target=development`: with buildx, unused build stages (e.g., prod stages) are skipped.
Configuration menu - View commit details
-
Copy full SHA for 046458b - Browse repository at this point
Copy the full SHA 046458bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c6ed8a - Browse repository at this point
Copy the full SHA 7c6ed8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 654627b - Browse repository at this point
Copy the full SHA 654627bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d65aacb - Browse repository at this point
Copy the full SHA d65aacbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4b2dc6 - Browse repository at this point
Copy the full SHA d4b2dc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 823fcdb - Browse repository at this point
Copy the full SHA 823fcdbView commit details
Commits on May 27, 2024
-
Switch remaining pnpx cases to pnpm exec
One case switched to pnpm dlx instead of pnpm exec because there's no package.json or node_modules in the test/e2e folder so pnpm exec would fail, but pnpm dlx will run the tool globally regardless of location.
Configuration menu - View commit details
-
Copy full SHA for ed5d194 - Browse repository at this point
Copy the full SHA ed5d194View commit details -
Need pnpm dlx in check-code-formatting workflow
Can't use `pnpm exec` here either since it's being run in a step where `pnpm i` has *not* happened, so there's no prettier binary to run.
Configuration menu - View commit details
-
Copy full SHA for f9f550d - Browse repository at this point
Copy the full SHA f9f550dView commit details