Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update field names to be consistent with FLEx #1731

Merged
merged 8 commits into from
Feb 24, 2023
Merged

Update field names to be consistent with FLEx #1731

merged 8 commits into from
Feb 24, 2023

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Feb 16, 2023 •
edited
Loading

Fixes #1730

Description

LF labels FLEx labels
Word Lexeme Form
Meaning Sense
Part of Speech Grammatical Category
Type Sense Type

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have updated tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

Testing

Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.

  • Ensure field names referenced in table above have changed to the correct label
  • Ensure there are no more old field name references in the project configuration area

@longrunningprocess longrunningprocess added the feature A improvement or feature label Feb 16, 2023
@longrunningprocess longrunningprocess self-assigned this Feb 16, 2023
@github-actions
Copy link

github-actions bot commented Feb 16, 2023 •
edited
Loading

Unit Test Results

362 tests   362 ✔️  19s ⏱️
  37 suites      0 💤
    1 files        0 ❌

Results for commit ea7fa0e.

♻️ This comment has been updated with latest results.

@longrunningprocess longrunningprocess enabled auto-merge (squash) February 16, 2023 20:17
@longrunningprocess longrunningprocess marked this pull request as draft February 22, 2023 15:02
auto-merge was automatically disabled February 22, 2023 15:02

Pull request was converted to draft

@longrunningprocess
Copy link
Contributor Author

moved to draft because we received more info from the requestor on fields, we'll need to do a little more work once final decisions are made...

@longrunningprocess longrunningprocess changed the title Use requested labels for Word and Meaning Update field names to be consistent with FLEx Feb 23, 2023
@longrunningprocess longrunningprocess marked this pull request as ready for review February 23, 2023 20:01
@longrunningprocess longrunningprocess enabled auto-merge (squash) February 23, 2023 20:09
megahirt
megahirt approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than verifying what "Sense Type" field label is used in FLEx, I approve of this PR. Thanks! This PR should match what FLEx has as far as field labels go.

@longrunningprocess longrunningprocess merged commit 3927735 into develop Feb 24, 2023
@longrunningprocess longrunningprocess deleted the feature/new-names-for-word-meaning branch February 24, 2023 12:57
@hahn-kev hahn-kev mentioned this pull request Mar 3, 2023
Open
longrunningprocess pushed a commit that referenced this pull request May 23, 2023
Revert "Update field names to be consistent with FLEx (#1731)"
64c03c0 
This reverts commit 3927735.
longrunningprocess pushed a commit that referenced this pull request May 26, 2023
Revert "Update field names to be consistent with FLEx (#1731)" (#1753)
8665061 
This reverts commit 3927735.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myieye myieye myieye left review comments

@megahirt megahirt megahirt approved these changes

Assignees

@longrunningprocess longrunningprocess

Labels
feature A improvement or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update labels to be more consistent with FLEx
3 participants
@longrunningprocess @megahirt @myieye