Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update labels to be more consistent with FLEx #1730

Open
megahirt opened this issue Feb 16, 2023 · 1 comment · Fixed by #1731
Open

update labels to be more consistent with FLEx #1730

megahirt opened this issue Feb 16, 2023 · 1 comment · Fixed by #1731

Comments

@megahirt
Copy link
Collaborator

megahirt commented Feb 16, 2023

This card is about changing the labels the user sees for the "word" and "meaning" fields.

Word -> Lexeme Form (or "Lexeme" - need clarification)
Meaning -> Sense

@longrunningprocess longrunningprocess changed the title update labels to "lexeme form" and "sense" update labels to be more consistent with FLEx Feb 23, 2023
@hahn-kev
Copy link
Collaborator

hahn-kev commented Mar 3, 2023

Reopening this because #1731 only changed the labels for new entries, not existing ones. Here's the conversation from slack:

Tim:

So...I believe we store the names of fields in Mongo, meaning the field renaming
@Billy Clark
did only applies to new projects. That's not what we were expecting is it? 😞

Billy:

looks like Meaning changed to Sense at least

Kevin:

Sad news, the field names are also in lf merge. here, it looks like it's only used for an empty option list, I'm not totally sure what that means, but I think it means that we can't use lf merge to just update all the labels for us after we make the change. So at this point I'm not sure what the best direction to take would be, I'm worried that stuff might break due to how invasive this change already is.What if we took a different approach and used a custom filter in angular. The only code we change would be in angular. The filter just looks at the input label and maps it to a different value via a lookup and if it's not there then it just uses the label passed in. Something like this:

let lookup = {
  "Part of Speech": "Grammatical Category"
}
function convertLabel(label) {
  return lookup[label] ?? label;
}

there would be a lot of places where we would have to make the change, and there's some other places like dialogs we would still have to change, but Billy already did that.

@hahn-kev hahn-kev reopened this Mar 3, 2023
@longrunningprocess longrunningprocess removed their assignment Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants