Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional BiblicalTermsListSetting element in the Settings.xml file #543

Open
mmartin9684-sil opened this issue Oct 2, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mmartin9684-sil
Copy link
Collaborator

machine/corpora/paratext_project_settings_parser_base.py treats the BiblicalTermsListSetting element in the Settings.xml file as a mandatory element. While Paratext projects will have this element, it is sometimes necessary to work with projects that do not have any Settings.xml file, and a simple Settings.xml file must be hand-constructed for it. Treating the BiblicalTermsListSetting element as mandatory means that this is another XML element that has to be provided in the hand-constructed file.
Treating this as optional file (perhaps with a warning message) would be convenient.

@mmartin9684-sil mmartin9684-sil added the enhancement New feature or request label Oct 2, 2024
@mshannon-sil
Copy link
Collaborator

@ddaspit If this seems good to you, I can go ahead and work on adding this to Machine and machine.py.

@ddaspit ddaspit removed their assignment Oct 2, 2024
@ddaspit
Copy link
Collaborator

ddaspit commented Oct 2, 2024

Yes, go for it. It should be pretty simple.

@mshannon-sil
Copy link
Collaborator

The fix has been made in machine.py. Once the next version of machine.py is released, we'll need to update the version of sil-machine in this repo. Then we can close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants