Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional BiblicalTermsListSetting element in the Settings.xml file #254

Closed
mshannon-sil opened this issue Oct 7, 2024 · 1 comment
Closed
Assignees
Labels

Comments

@mshannon-sil
Copy link
Collaborator

mshannon-sil commented Oct 7, 2024

From issue 543 in SILNLP: "machine/corpora/paratext_project_settings_parser_base.py treats the BiblicalTermsListSetting element in the Settings.xml file as a mandatory element. While Paratext projects will have this element, it is sometimes necessary to work with projects that do not have any Settings.xml file, and a simple Settings.xml file must be hand-constructed for it. Treating the BiblicalTermsListSetting element as mandatory means that this is another XML element that has to be provided in the hand-constructed file.
Treating this as optional file (perhaps with a warning message) would be convenient."

Since machine.py will be changing, we'll need to make a corresponding change in Machine in src/SIL.Machine/Corpora/ParatextProjectSettingsParserBase.cs.

@mshannon-sil
Copy link
Collaborator Author

This was actually a bug specific to machine.py that occurred during the porting process from C# to Python, so no changes in Machine are needed.

@mshannon-sil mshannon-sil closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant