Added IncludeSourceRevisionInInformationalVersion to SampleApp so Version doesn't get added garbage #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so that Version doesn't get added garbage Added some test code to the sample app to try to re-create and diagnose problem the Bloom team encountered.
andrew-polk
reviewed
Oct 29, 2024
There was a problem hiding this comment.
I think this is obsolete with #120
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @tombogle)
…rict (default) and permissive initialization mode
|
I guess that is mostly true. But since we do have the StrictInitializationMode property, I've made it so the SampleApp can properly test the behavior when that is set to false and also (bit more subtly) demonstrate the expected behavior when true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some test code to the sample app to try to re-create and diagnose problem the Bloom team encountered.
This change is